Skip to content
This repository has been archived by the owner on Jul 26, 2023. It is now read-only.

Fix parameter propagation in helper method #127

Merged
merged 1 commit into from
Jan 1, 2016
Merged

Conversation

AArnott
Copy link
Collaborator

@AArnott AArnott commented Dec 28, 2015

I found this while looking for IntPtr parameter types for #76. It seems this parameter was ignored, and didn't use the type that was created for it. This fixes both issues.

@AArnott AArnott added the bug label Dec 28, 2015
@AArnott AArnott added this to the 0.1.0 (stable) milestone Dec 28, 2015
IntPtr.Zero,
0,
requiredSize,
null);
deviceInfoData);
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see this argument was missing only from the first call (the "how big should the buffer be?" call). So perhaps that's by design?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually it seems missing from both calls. So this seems like the right fix.

AArnott added a commit that referenced this pull request Jan 1, 2016
Fix parameter propagation in helper method
@AArnott AArnott merged commit b4d14af into master Jan 1, 2016
@AArnott AArnott deleted the fix76_setupapi branch January 1, 2016 03:39
@vbfox
Copy link
Collaborator

vbfox commented Jan 1, 2016

Yes look like a stupid mistake on my part

@AArnott
Copy link
Collaborator Author

AArnott commented Jan 1, 2016

Thanks for looking, @vbfox

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants